Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer mark test_rename_type_mismatch as xfailing #1161

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 16, 2022

The blocking issue, dandi/dandi-archive#1109, was resolved.

@jwodder jwodder added the tests Add or improve existing tests label Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 88.26% // Head: 88.19% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (77a380e) compared to base (15ea79f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1161      +/-   ##
==========================================
- Coverage   88.26%   88.19%   -0.07%     
==========================================
  Files          73       73              
  Lines        8805     8804       -1     
==========================================
- Hits         7772     7765       -7     
- Misses       1033     1039       +6     
Flag Coverage Δ
unittests 88.19% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/test_dandiapi.py 100.00% <ø> (ø)
dandi/support/threaded_walk.py 93.10% <0.00%> (-1.73%) ⬇️
dandi/organize.py 82.81% <0.00%> (-0.45%) ⬇️
dandi/dandiapi.py 88.28% <0.00%> (-0.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member

Thank you !

@yarikoptic yarikoptic merged commit b11835a into master Nov 16, 2022
@yarikoptic yarikoptic deleted the rm-xfail branch November 16, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants