Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for ls reinstated, underlying function fixed, support for ZARR-BIDS files added. #1164

Merged
merged 37 commits into from
Dec 12, 2022
Merged

Tests for ls reinstated, underlying function fixed, support for ZARR-BIDS files added. #1164

merged 37 commits into from
Dec 12, 2022

Commits on Dec 2, 2022

  1. Unravelling ls issues

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    d3ec5f1 View commit details
    Browse the repository at this point in the history

  2. strange Cannot creat weak reference to PosixPath object

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    dc34ab0 View commit details
    Browse the repository at this point in the history

  3. Fixed weakref issue

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    8aef541 View commit details
    Browse the repository at this point in the history

  4. Added readme listing and removed some diagnostic print calls

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    b3a4b9a View commit details
    Browse the repository at this point in the history

  5. Removed more debugging print calls

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    3272c86 View commit details
    Browse the repository at this point in the history

  6. Removed more debugging print calls

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    ba99146 View commit details
    Browse the repository at this point in the history

  7. Creating and passing digests

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    64677c1 View commit details
    Browse the repository at this point in the history

  8. Added validation bids schema version to result object metadata

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    f8a0da8 View commit details
    Browse the repository at this point in the history

  9. Assigning bids schema version for validation to metadata dict

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    430fb06 View commit details
    Browse the repository at this point in the history

  10. Trying to insert bids_schema_version ... somewhere.

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    279ecf9 View commit details
    Browse the repository at this point in the history

  11. Added (get_validation)_bids_version to BIDS assets 

    This might be better moved to metadata but that will require updating
bids_schema.

additionally removed most debugging print calls
    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    60b2408 View commit details
    Browse the repository at this point in the history

  12. Creating ZARR digest for ZARR files

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    4a4530e View commit details
    Browse the repository at this point in the history

  13. Using correct ZARR digest class (still not working) 

    included debug print calls
    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    9df52ad View commit details
    Browse the repository at this point in the history

  14. More debugging print calls trying to track down digest error

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    0e0ff8e View commit details
    Browse the repository at this point in the history

  15. Removed unneeded import

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    cc28fbb View commit details
    Browse the repository at this point in the history

  16. Using zarr extensions variable from constants module

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    5d59ae8 View commit details
    Browse the repository at this point in the history

  17. Reinstated fake digest after introducing ZARR conditional

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    5d62fcc View commit details
    Browse the repository at this point in the history

  18. Attempting to fix digest type conflict (still not working)

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    f0de103 View commit details
    Browse the repository at this point in the history

  19. Use Zarr checksum to set metadata contentSize

    @jwodder @TheChymera
    jwodder authored and TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    86ae9c0 View commit details
    Browse the repository at this point in the history

  20. Removed debugging print calls

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    9866d0c View commit details
    Browse the repository at this point in the history

  21. Not requiring bids_version for ValidatorOrigin 

    since NWB objects will not necessarily have this
    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    785dec0 View commit details
    Browse the repository at this point in the history

  22. Typing fixes and improved variable name

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    2059dd7 View commit details
    Browse the repository at this point in the history

  23. Attemting type check fix for missing attribute 

    get_validation_bids_version
    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    a2119ec View commit details
    Browse the repository at this point in the history

  24. Removed commented imports

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    722e804 View commit details
    Browse the repository at this point in the history

  25. Actually fix typing

    @jwodder @TheChymera
    jwodder authored and TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    3649b5e View commit details
    Browse the repository at this point in the history

  26. Debugging upload tests

    @TheChymera
    TheChymera committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    32d0379 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Reinstating test

    @TheChymera
    TheChymera committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    ba7d60c View commit details
    Browse the repository at this point in the history

  2. Associate BIDS asset errors with the actual assets

    @jwodder
    jwodder committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    e8a64e1 View commit details
    Browse the repository at this point in the history

  3. Fixed novel README validation error 

    The ad-hoc fix for README listing when validating single files was
adding it twice. big fail.
    @TheChymera
    TheChymera committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    ccda9ec View commit details
    Browse the repository at this point in the history

  4. Checking ls output subject identifier 

    Closes: #1097
    @TheChymera
    TheChymera committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    44a8ab4 View commit details
    Browse the repository at this point in the history

  5. Added ls command tests for zarrBIDS file 

    Closes: #1038
    @TheChymera
    TheChymera committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    efab43e View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. ZARR-appropriate fake checksum 

    Co-authored-by: John T. Wodder II <[email protected]>
    @TheChymera @jwodder
    TheChymera and jwodder committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    1ed0f5f View commit details
    Browse the repository at this point in the history

  2. More compact code 

    Co-authored-by: John T. Wodder II <[email protected]>
    @TheChymera @jwodder
    TheChymera and jwodder committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    9900841 View commit details
    Browse the repository at this point in the history

  3. Dot in extension 

    Co-authored-by: John T. Wodder II <[email protected]>
    @TheChymera @jwodder
    TheChymera and jwodder committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    3384ef5 View commit details
    Browse the repository at this point in the history

  4. Safer assert satatement 

    Co-authored-by: John T. Wodder II <[email protected]>
    @TheChymera @jwodder
    TheChymera and jwodder committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    d9ccf8b View commit details
    Browse the repository at this point in the history

  5. Making sure the method which sets the attribute has been run

    @TheChymera
    TheChymera committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    375947d View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Updated logic to better accommodate future BIDS NWB examples

    @TheChymera
    TheChymera committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    11c18f5 View commit details
    Browse the repository at this point in the history