#79 - Support and test for images & replaceds over two or more pages.

For images that continue over more than one page, just mark the portion on the second and subsequent pages as an artifact. The spec (PDF 1.7) is not clear on what to do in this situation.
danfickle · Jan 21, 2019 · d43af23 · d43af23
1 parent ce6b7e9
commit d43af23
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/...mltopdf-examples/src/main/java/com/openhtmltopdf/testcases/pdfua/PdfUaTestcaseRunner.java b/...mltopdf-examples/src/main/java/com/openhtmltopdf/testcases/pdfua/PdfUaTestcaseRunner.java
@@ -44,5 +44,6 @@ public static void main(String... args) throws Exception {
         run("layers-z-index");
         run("text-over-two-pages");
         run("image");
+        run("image-over-two-pages");
     }
 }
diff --git a/openhtmltopdf-examples/src/main/resources/testcases/pdfua/image-over-two-pages.html b/openhtmltopdf-examples/src/main/resources/testcases/pdfua/image-over-two-pages.html
@@ -0,0 +1,17 @@
+<html lang="EN-US">
+<head>
+<title>Image over two pages for PDF/UA</title>
+<style>
+  @page {
+    size: 200px 200px;
+    margin: 0;
+  }
+  body {
+    margin: 0;
+  }
+</style>
+</head>
+<body style="font-family: 'TestFont';">
+  <img style="width: 150px; height: 320px; display: block;" src="../../demos/images/flyingsaucer.png" alt="Sample Image Alt Text: Flyingsaucer"/>
+</body>
+</html>
diff --git a/...htmltopdf-pdfbox/src/main/java/com/openhtmltopdf/pdfboxout/PdfBoxAccessibilityHelper.java b/...htmltopdf-pdfbox/src/main/java/com/openhtmltopdf/pdfboxout/PdfBoxAccessibilityHelper.java
@@ -407,8 +407,14 @@ public Object startStructure(StructureType type, Box box) {
                 if (current != null) {
                     _cs.beginMarkedContent(COSName.getPDFName(StandardStructureTypes.Figure), current.dict);
                     return Boolean.TRUE;
+                } else {
+                    // For images that continue over more than one page, just mark the portion on the second
+                    // and subsequent pages as an artifact. The spec (PDF 1.7) is not clear on what to do in this
+                    // situation.
+                    COSDictionary bg = createBackgroundArtifact(type, box);
+                    _cs.beginMarkedContent(COSName.ARTIFACT, bg);
+                    return Boolean.TRUE;
                 }
-                return Boolean.FALSE;
             }
             default: {
                 return Boolean.FALSE;