Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#493 Auto extraction of SVG styles to pass to Batik SVG renderer. #515

Merged
merged 7 commits into from
Jul 21, 2020
Merged

#493 Auto extraction of SVG styles to pass to Batik SVG renderer. #515

merged 7 commits into from
Jul 21, 2020

Commits on Jul 17, 2020

  1. #493 Failing test for CSS not passed to SVG renderer.

    @danfickle
    danfickle committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    3b28992 View commit details
    Browse the repository at this point in the history

  2. #493 Clean up mapper while understanding how it works. 

    Need to write a new mapper to retrieve styles for SVGs.
    @danfickle
    danfickle committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    3bd9343 View commit details
    Browse the repository at this point in the history

  3. #493 Semi working proof of concept on extracting SVG CSS styles. 

    Still needs work on passing through CSS properties tht are not valid in HTML but valid in SVG such as the fill property.
    @danfickle
    danfickle committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    f1284f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2020

  1. #493 Keep invalid property declarations in the CSS parser 

    So they can be passed to SVG plugin. Test is now working well, but proof will be provided in a separate commit.
    @danfickle
    danfickle committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    4a2cf8e View commit details
    Browse the repository at this point in the history

  2. #493 Suppress warnings about SVG properties not being implemented.

    @danfickle
    danfickle committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    62ada2e View commit details
    Browse the repository at this point in the history

  3. #493 Test proof that auto extraction of SVG styles is working.

    @danfickle
    danfickle committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    f038dd0 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. #493 Test applying styles to external SVG linked via img tag. 

    Copy the class attribute from img tag to svg tag so it can be better targetted.
    @danfickle
    danfickle committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    33ad1b5 View commit details
    Browse the repository at this point in the history