Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use hmac compare instead of direct compare #1

Merged
merged 1 commit into from
Dec 11, 2018
Merged

use hmac compare instead of direct compare #1

merged 1 commit into from
Dec 11, 2018

Commits on Dec 11, 2018

  1. use hmac compare instead of direct compare 

    As per https://api.slack.com/docs/verifying-requests-from-slack - "Compare the resulting signature to the header on the request. Note: for best practice, use an hmac compare function instead of directly comparing the signatures for equality."
    @danhofer
    danhofer authored Dec 11, 2018
    Configuration menu
    Copy the full SHA
    56fecd0 View commit details
    Browse the repository at this point in the history