Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapsible config option can cause orphaned nodes to not be displayed #129

Closed
sammaniamsam opened this issue Oct 11, 2018 · 2 comments · Fixed by #154
Closed

Collapsible config option can cause orphaned nodes to not be displayed #129

sammaniamsam opened this issue Oct 11, 2018 · 2 comments · Fixed by #154
Labels
bug priority low

Comments

@sammaniamsam
Copy link

From the docs :

@param {boolean} [collapsible=false] - 🚅🚅🚅 Allow leaf neighbours nodes to be collapsed (folded), this will allow users to clear the way out and focus on the parts of the graph that really matter.

This option should not collapse disconnected nodes (orphaned nodes) by default. Right now, it does. This has been tested using the latest master branch.
danielcaldas added a commit that referenced this issue Oct 14, 2018
@danielcaldas
Add note in graph.config about issue #129
1add352
danielcaldas added a commit that referenced this issue Oct 15, 2018
@danielcaldas
Feature/directional graph (#132)
765b8ae 
* Add marker component

* Add marker.const

* Render markers at graph level

* Create marker.helper. Replace arrowId for markerId naming

* Memoize operations to fetch marker id

* Add markers only in directed graphs

* Add size constatns to marker.const

* Memoize defs for markers

* Documentation for marker.helper

* Fix regression in graph.helper on link.types

* Update several tests and revert graph.config changes

* Fix comment on sandbox node click

* Add collapse.helper.js

* Properly config eslint for jest

* Fix sandbox no initial config provided

* Correct collapsible behavior for directed graphs with isNodeVisible

* Add @memberof for collapse.helper

* Pass click node handler as setState callback

* Clean collapse code in Graph component and graph.heler

* Add marker snapshot tests

* Add marker.helper tests

* Remove FIXME on sandbox resolved with initial config fix

* Small detail valid jsdoc for _tick

* Fix state transition between active/inactive collapsible config

* Fix bad call to toggleLinksMatrixConnections in Graph.jsx

* Differ condition to check leaf node for directed graphs

* Add eslint-plugin-cypress

* Add 'directed' to sandbox.po whitelist of checkboxes

* Add marker className to marker component

* Add e2e tests for directed graph

* Small lint fix

* Fix scenario for toggling directed config

* Add note in graph.config about issue #129

* Improvements in collapse.helper

* Write more unit tests for toggleLinksConnections

* Add module to eslint globals

* Support fullscreen query param on sandbox

* Add marvel dataset to sandbox

* Add jsdoc for directed config

* Code review
@danielcaldas
Copy link
Owner

A possible strategy to fix this issue would be to tag orphan nodes when initializing graph state, this could be tricky tough since initialization can re-occur along the way in the same graph lifecycle... This needs to be planned carefully, thanks for reporting.

@stale stale bot added the wontfix label Nov 24, 2018
@stale stale bot closed this as completed Dec 14, 2018
Repository owner deleted a comment from stale bot Dec 17, 2018
@danielcaldas danielcaldas reopened this Dec 17, 2018
@danielcaldas danielcaldas mentioned this issue Dec 19, 2018
Merged
@danielcaldas
Copy link
Owner

Closing this with #154

@danielcaldas danielcaldas mentioned this issue May 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/collapsible orphan nodes and last node danielcaldas/react-d3-graph
2 participants
@danielcaldas @sammaniamsam