-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sandbox] Fail to remove links / nodes in the live demo example #212
Comments
Now that I'm reading the description of the issue with more attention, this is not actually a bug. If you remove a node you must ensure that the respective links, that refer that node are also removed. But removing a link tough, should not fail... even if some node becomes orphan afaik, the graph should not break. This is the behavior that is implemented in the Sandbox for the I'll look into it with more detail, can't promise that I'm come out with a solution in short notice tough. |
Actually, I think I got it! Somehow react-editable-json-tree is giving us |
Hello @danielcaldas , |
All good! Your docs are awesome @oxyno-zeta! I'll be using |
Thanks :) |
Fixed with #216 |
Describe the bug
The sandbox example breaks when the user tries to remove an item by using the
-
links found in the editable Graph Data section. This applies to both nodes or links.To Reproduce
Steps to reproduce the behavior:
links
ornodes
property in the Graph Data section of the page-
button next to the link / node that you wish to removeExpected behavior
The selected node or link should dissappear from the editable data view and the graph shall be updated accordingly.
Additional context
When trying to remove a link, the following error is displayed at the developer's console:
If the item you're trying to delete is a node, then the following error is shown instead:
The text was updated successfully, but these errors were encountered: