Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Fail to remove links / nodes in the live demo #216

Merged
merged 5 commits into from
Aug 8, 2019
Merged

Fix/Fail to remove links / nodes in the live demo #216

merged 5 commits into from
Aug 8, 2019

Conversation

danielcaldas
Copy link
Owner

This PR fixes #212

  • On sandbox onGraphDataUpdate properly handle removing links and nodes
  • On sandbox create onBeforeRemoveGraphData function to allows us to keep track of removed elements in out state
  • Small styles updates for better right side form on small viewports

@danielcaldas danielcaldas merged commit b431b82 into master Aug 8, 2019
@danielcaldas danielcaldas mentioned this pull request Aug 8, 2019
Closed
@danielcaldas danielcaldas deleted the fix/sandbox-react-json-tree-data-integration branch August 8, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Sandbox] Fail to remove links / nodes in the live demo example
1 participant
@danielcaldas