Feature/link labels (#101) #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to fix all the tests but I suppose you are still working on some features. |
danielcaldas
reviewed
Oct 3, 2018
danielcaldas
force-pushed
the
feature/directional-graph
branch
2 times, most recently
from
c866acd
to
102ea54
Compare
danielcaldas
force-pushed
the
feature/directional-graph
branch
2 times, most recently
from
0a527f1
to
34e68fe
Compare
|
Hello there @Droow! The directed graph branch was merged now. If you wanna give it a try go ahead now! |
|
Hey there @Droow just created the branch feature/labels-on-links where I resolved the conflicts and did some cleaning, you can resume your work from there, if you're not interested in continue please let me know. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I needed to add labels to links (edges) and since there are a few other issues regarding this subject (#101 and #47) I decided to give it a go and implement it. I build it on top of your directional-graph branch because I needed this feature too.
Font color, weight and size can be changed in the same way as with nodes (via config or per link). Also you can choose from which property is the label coming from (same as node's labelProperty). For now, these labels are exactly in the middle of link and are copying its curve. If necessary it can be easily moved to config.
Let me know if you want me to change something or add more config options. Hope it helps!