fix: Trigger custom click handler in collapsible nodes #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a mistake in the `_tick` method which caused the user's `onNodeClick` custom handler to never be triggered when the collapsible feature was enabled. The problem was that it called `setState` without using a callback parameter if the received `cb` was not empty. The contents of that ternary operator should be the opposite for things to work. This fix closes #136.
|
My bad! 😓 🔥 Just added a e2e test to ensure the functionality |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mistake in the
_tickmethod which caused the user'sonClickNodecustom handler to never be triggered when the collapsiblefeature was enabled.
The problem was that it called
setStatewithout using a callbackparameter if the received
cbwas not empty. The contents of thatternary operator should be the opposite for things to work.
This fix closes #136.