fix: Add link with custom color in existing graph #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new link was added in real time by updating an existing graph instance, if it was configured to have a custom color with the 'link.color' property, that value was ignored and the default color was displayed instead. This issue was reported in #169. The source of the problem was that, when generating a d3Link instance in the '_mapDataLinkToD3Link' method, the value of the color property was not kept. Only the source and target values were being added to the d3Link which would actually be rendered in the graph, and the color property was completely lost by the time the graph was to be drawn on the screen. The issue could be solved by adding a color property to the d3Link object.
|
Hey thanks for the fix @LonelyPrincess, just did a small adjustment so that we properly support the other link level properties as well, this was introduced in the PR #166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new link was added in real time by updating an existing graph instance, if it was configured to have a custom color with the
link.colorproperty, that value was ignored and the default color was applied instead. This issue was reported in #169.The source of the problem was that, when generating a
d3Linkinstance in the_mapDataLinkToD3Linkmethod, the value of thecolorproperty was not kept.Only the
sourceandtargetvalues were being added to thed3Linkwhich would actually be rendered in the graph, and thecolorproperty was completely lost by the time the graph was to be drawn on the screen. The issue could be solved by adding acolorproperty to the generatedd3Linkobject.