-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save picture crash in demos on iOS 11+ #3311
Comments
I just tried on my phone, it works expected, asking for permit, and once you allow it it will save to camera roll. |
Hi @liuxuan30 I don't believe this bug was fixed. What is currently in the Info.plist is the This is still crashing on simulators. I'll be more than happy to open a pull request to fix this if you reopen the issue |
I remember it's 10.2 system. Not tested on 11 yet. |
Thanks for reporting! |
My pleasure! We're really pleased with your library, used on a couple commercial projects and I'm glad to see it's actively supported :) If I had some questions on displaying more custom controls / labels where would it be appropriate to ask that? |
Glad to hear that :) Though the author has been inactive for quite a long time, we are lucky to have some collaborators working on it, though slowly. Asking on SO can reduce our Github inbox size, so we can focus on something else. |
* 'master' of https://github.com/danielgindi/Charts: fix ChartsOrg#3311. Need one more key for iOS 11 camera roll saving revert a mistake, fix ChartsOrg#3299
* master: (55 commits) Refactors -[tableView:cellForRowAtIndexPath:] (ChartsOrg#3326) fix ChartsOrg#3311. Need one more key for iOS 11 camera roll saving revert a mistake, fix ChartsOrg#3299 add pie chart unit tests (ChartsOrg#3297) ChartsOrg#3287: align Objc and Swift demos balloon marker update changelog Min and Max reset when clearing ChartDataSet (Fixes ChartsOrg#3260) Restored old performance (ChartsOrg#3216) Support other bundle than main MarkerView.viewFromXib() (ChartsOrg#3215) For ChartsOrg#2840. add dataIndex parameter in `highlightValue()` calls (ChartsOrg#2852) Balloon Marker indicates position of data (ChartsOrg#3181) bump Info.plist version Fixed a duplicated assignment compared with obj-c code. (ChartsOrg#3179) Updated README for 3.0.5 (ChartsOrg#3183) BubbleChart uses correct colour for index now. Added custom text alignment for noData Fixes the distance issue between the legend and the horizontal bar chart (Fixes ChartsOrg#2138) (ChartsOrg#2214) call setNeedsDisplay() here to trigger render noDataText (ChartsOrg#3198) 添加定制TY的Mark 添加修改过的Mark到工程中 ... # Conflicts: # ICXCharts.podspec
liuxuan30 Great Answer Work for me...... |
Great Answer Work for me...... |
As of iOS 11, Apple requires developers to declare the use of write-only photos action. Otherwise the app crashes when trying to save a pictures.
This is an issue on the ChartsDemo apps.
Steps to reproduce
Environment
Tested on iPhone 8 Plus 11.1 simulator.
I had the same issue happen to me on physical devices too.
Crash log
Fix
Fixing this is quite simple. Just add the following lines to the Info.plist
The text was updated successfully, but these errors were encountered: