Balloon Marker indicates position of data #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3181 +/- ##
==========================================
- Coverage 22.98% 22.95% -0.04%
==========================================
Files 116 116
Lines 15542 15786 +244
Branches 272 282 +10
==========================================
+ Hits 3573 3623 +50
- Misses 11933 12127 +194
Partials 36 36
Continue to review full report at Codecov.
|
liuxuan30
reviewed
Jan 22, 2018
| x: rect.origin.x, | ||
| y: rect.origin.y)) | ||
| context.fillPath() | ||
| if offset.y > 0 { |
| point.x -= size.width / 2.0 | ||
| point.y -= size.height | ||
| return super.offsetForDrawing(atPoint: point) | ||
| var offset = self.offset |
There was a problem hiding this comment.
So you just port the new marker for both Objc and Swift? Any new content based on #1741 ?
seems good to go
There was a problem hiding this comment.
Yea, I didn't make any changes to what #1741 provided. Just wanted to get the example merged and the author wasn't responding.
liuxuan30
approved these changes
Jan 23, 2018
FreddyZeng
added a commit
to FreddyZeng/Charts
that referenced
this pull request
Jan 31, 2018
* 'master' of https://github.com/danielgindi/Charts: Restored old performance (ChartsOrg#3216) Support other bundle than main MarkerView.viewFromXib() (ChartsOrg#3215) For ChartsOrg#2840. add dataIndex parameter in `highlightValue()` calls (ChartsOrg#2852) Balloon Marker indicates position of data (ChartsOrg#3181) bump Info.plist version BubbleChart uses correct colour for index now. # Conflicts: # Source/Charts/Mark/BalloonMarker.swift
kzyryanov
pushed a commit
to fishbrain/Charts
that referenced
this pull request
Feb 20, 2018
* Reimplemented ChartsOrg#1741 * Fixed code style
kalmurzayev
pushed a commit
to kalmurzayev/Charts
that referenced
this pull request
Feb 26, 2018
* Reimplemented ChartsOrg#1741 * Fixed code style
FreddyZeng
added a commit
to FreddyZeng/Charts
that referenced
this pull request
Mar 14, 2018
* master: (55 commits) Refactors -[tableView:cellForRowAtIndexPath:] (ChartsOrg#3326) fix ChartsOrg#3311. Need one more key for iOS 11 camera roll saving revert a mistake, fix ChartsOrg#3299 add pie chart unit tests (ChartsOrg#3297) ChartsOrg#3287: align Objc and Swift demos balloon marker update changelog Min and Max reset when clearing ChartDataSet (Fixes ChartsOrg#3260) Restored old performance (ChartsOrg#3216) Support other bundle than main MarkerView.viewFromXib() (ChartsOrg#3215) For ChartsOrg#2840. add dataIndex parameter in `highlightValue()` calls (ChartsOrg#2852) Balloon Marker indicates position of data (ChartsOrg#3181) bump Info.plist version Fixed a duplicated assignment compared with obj-c code. (ChartsOrg#3179) Updated README for 3.0.5 (ChartsOrg#3183) BubbleChart uses correct colour for index now. Added custom text alignment for noData Fixes the distance issue between the legend and the horizontal bar chart (Fixes ChartsOrg#2138) (ChartsOrg#2214) call setNeedsDisplay() here to trigger render noDataText (ChartsOrg#3198) 添加定制TY的Mark 添加修改过的Mark到工程中 ... # Conflicts: # ICXCharts.podspec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplemented #1741