-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme with attributes rendering #299
base: olio-theme
Are you sure you want to change the base?
Conversation
# Conflicts: # package.json
1 similar comment
👍 Awesome Job ! @bniwredyc We're looking forward to it. Wish it to be merged sooner or later. |
@danielgtaylor Could merge this pull requests soon? We're so looking forward to it that aglio could rendering the attributes. |
Any updates on this? Missing this feature so much. |
This only appears to work with Attributes in Request sections, not in any other Resource, Action or Payload. |
.npmignore
Outdated
@@ -1,6 +1,5 @@ | |||
coverage | |||
node_modules | |||
src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats the reason behind this being removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember exactly, but i think I needed it for debugging. Returned it.
templates/index.jade
Outdated
@@ -12,7 +12,7 @@ html | |||
a.text-muted.back-to-top(href='#top') | |||
i.fa.fa-toggle-up | |||
| Back to top | |||
div(class=self.fullWidth ? 'container-fluid' : 'container') | |||
div(class='container-fluid') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for this being hard-coded to container-fluid
now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I remember I liked it more :) Reverted.
templates/scripts.js
Outdated
@@ -217,7 +217,7 @@ function init() { | |||
init(); | |||
|
|||
window.onload = function () { | |||
autoCollapse(); | |||
// autoCollapse(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come this was commented out? Looks like it might be causing the issue with the collapsables that @OrangeDog mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That string just collapses the left menu on page load. Returned it too for clarity.
This might be better achieved using https://github.com/apiaryio/attributes-kit? I've no idea how to integrate it, however. |
@jackbentley a bird in the hand is worth two in the bush :) |
No description provided.