Do not create empty object for empty directory in S3 artifact reposit…

…ory (mlflow#12415) Signed-off-by: harupy <[email protected]> Signed-off-by: Daniel Lok <[email protected]>
daniellok-db · Jun 20, 2024 · b525ca3 · b525ca3
1 parent d491995
commit b525ca3
Showing 1 changed file with 0 additions and 4 deletions.
diff --git a/mlflow/store/artifact/s3_artifact_repo.py b/mlflow/store/artifact/s3_artifact_repo.py
@@ -190,10 +190,6 @@ def log_artifacts(self, local_dir, artifact_path=None):
                 rel_path = relative_path_to_artifact_path(rel_path)
                 upload_path = posixpath.join(dest_path, rel_path)
 
-            if not filenames:
-                # We're in an empty directory. Create a folder to preserve the directory structure.
-                s3_client.put_object(Bucket=bucket, Key=upload_path + "/")
-
             for f in filenames:
                 self._upload_file(
                     s3_client=s3_client,