-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global throttle speed limit #112
Comments
I see, I will think about how to add this, a speed limit option per assist level is a bit problematic. I guess in your use case as soon as you touch the throttle the bike should stop providing power if your are above 6km/h even if you are still pedaling? A global option might work which could limit speed for throttle on all "Standard" assist levels? |
A global option is ok for me, too. yes over 6km/h I will pedaling with motor help until 25km/h. Thx, l send a small donation for you. Thomas |
Hi yes this option is essential for the standard mode for Europeans because we have crappy regulations 😅 |
I'm also interested in this becaus here in Switzerland you can use the trottle up to 20 km/h legaly. A global trottle limit in standard mode would also be fine for me. Thank you so much for this project, i will keep sending donations for every new version. |
Hello The accelerator limitation at 6 km/h is planned for 1.4.0 ? |
Yes its planned for 1.4.0. I was working on it this evening but I had missed DonJohnLongs comment which makes things a bit more complicated so I will have to start over. I can not really give you an eta as I'm not regularly working on this, only when there is time/energy. |
Hi for my country the top is map the walking mode with the throttle |
* Implement global throttle speed limit option overriding configured assist level speed limit when throttle is used. * Throttle always overrides PAS when global throttle speed limit is configured. * Rework logic around current ramp up/down to always compute after all limit functions have been applied.
bbsfw.txt |
* Implement global throttle speed limit option overriding configured assist level speed limit when throttle is used. * Throttle always overrides PAS when global throttle speed limit is configured. * Rework logic around current ramp up/down to always compute after all limit functions have been applied.
* Implement global throttle speed limit option overriding configured assist level speed limit when throttle is used. * Throttle always overrides PAS when global throttle speed limit is configured. * Rework logic around current ramp up/down to always compute after all limit functions have been applied.
* Implement global throttle speed limit option overriding configured assist level speed limit when throttle is used. * Throttle always overrides PAS when global throttle speed limit is configured. * Rework logic around current ramp up/down to always compute after all limit functions have been applied.
* Implement global throttle speed limit option overriding configured assist level speed limit when throttle is used. * Throttle always overrides PAS when global throttle speed limit is configured. * Rework logic around current ramp up/down to always compute after all limit functions have been applied.
Just tried this and I'm not sure... :/ Throttle alone: Global Speed Limit applies 👍 In the UK/EU, the throttle only needs to be limited to 6kmh when used independently. When peddling, the throttle can be used as normal up to the 25kmh speed limit. Even if PAS is disabled, so long as the peddles are turning, the throttle is allowed. So basically I think the Global Speed Limit should only be applied when the peddles are not turning. If the peddles are turning then this limit/feature should be ignored :) |
Didn't know the law was that clear about this, maybe I was wrong. It was by design. The issue was originally about mapping walk mode on throttle. PAS cannot override throttle then because if the pedals starts spinning, either by accident or if motor is old and has started binding then the bike would take off... |
I think mapping walk mode came up but that's not where it started ;) You wouldn't need PAS to override the throttle. Just ignore the global speed limit on the throttle if the peddles are turning :) |
I'm not sure I understand. If we make it behave as no global speed limit is configured, then throttle will override PAS when requested current from throttle press is larger than the configured PAS current giving a smooth transition from PAS to throttle. The opposite is also true, PAS overrides throttle when configured PAS current is greater than requested throttle current. Then we implement global throttle speed limit as follows:
If that is what you are saying then that is the problem I tried to describe. Given the rules above. If you are walking with you bike with 4% throttle current and limited to 6kph, you hit a stone with you pedal and it starts spinning. PAS current is configured to 30%. Then the global throttle speed limit will not apply since pedals are spinning and PAS current was configured to 30% which is more than 4% and the bike will take off. |
Well that could happen when walking the bike without throttle. Or even when you're just standing with your bike and you just knock the peddle🤷♂️ lol But the 6kmh independent throttle limit is not for walking anyway, it's for startup at traffic lights or hills, etc. The walk mode is for walking ;) |
Hi Daniel,
i test your firmware with an BBSHD today the first time. Very nice first impression.
I have a feature request or i doesn’t find the settings:
In Germany is throttle only allowed, when is not faster then 6km/h. But with PAS is allowed until 25km/h. I will use the throttle as a starting helper until 6km/h. I found only the power limitation for the throttle but not an speed limit.
I need a speed limit for the throttle per assists level.
Thank you for the very great project.
Thomas
The text was updated successfully, but these errors were encountered: