Set RootCAs to nil in default case. #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we create an empty CA store, which is not a very useful default. The documentation for [cryto/tls#Config](https://godoc.org/crypto/tls#Config) says: > If RootCAs is nil, TLS uses the host's root CA set. I want to use this with confluent cloud, that is using certificates signed by a proper root CA. So loading the system CAs makes everything work properly just by enabling tls `--tls.enabled`
|
📝 @danielqsj ... this is still an issue... any chance you could review this PR? |
|
@errm sorry, I miss this. LGTM, thanks~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we create an empty CA store, which is not a very useful
default.
The documentation for cryto/tls#Config says:
I want to use this with confluent cloud, that is using certificates
signed by a proper root CA. So loading the system CAs makes everything
work properly just by enabling tls
--tls.enabled