Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rake to be able to run tests #58

Merged
merged 2 commits into from
May 16, 2024

Conversation

grosser
Copy link
Contributor

@grosser grosser commented May 9, 2024

rake
rake aborted!
NoMethodError: undefined method `=~' for #<Proc:0x00000001001f7e48 rake-10.5.0/lib/rake/application.rb:393 (lambda)>
bundler-2.5.10/lib/bundler/cli/exec.rb:58:in `load'
bundler-2.5.10/lib/bundler/cli/exec.rb:58:in `kernel_load'
bundler-2.5.10/lib/bundler/cli/exec.rb:23:in `run'

cc @Fryguy

@Fryguy Fryguy self-assigned this May 13, 2024
@Fryguy
Copy link
Collaborator

Fryguy commented May 13, 2024

This seems to be failing during setup of Ruby 2.2. It's getting a weird error about Marshal failing when trying to install bundler (note that later I re-ran the failed builds and now I see a segfault). This isn't an issue with this PR/gem, but looks more like a possible bug with ruby/setup-ruby, since they claim to still "support" Ruby 2.2? It's hard to tell.

So, we can either try to fix that path, or just remove 2.2 and below and drop support for those since they are so old (or both). @grosser thoughts?

@grosser
Copy link
Contributor Author

grosser commented May 14, 2024

updated to have nicer CI names + dropped support for <2.7 + added support for 3.1-3.3

@Fryguy
Copy link
Collaborator

Fryguy commented May 16, 2024

LGTM - I think this would warrant a major version bump (or at least a minor version bump).

@grosser
Copy link
Contributor Author

grosser commented May 16, 2024

afaik no need to bump major since nobody can install the new version on the old rubies + lots of gems do this all the time on minors, but 🤷
... the major bump should be when #59 is removed

@grosser
Copy link
Contributor Author

grosser commented May 16, 2024

plz merge either way, I can't do it

@Fryguy Fryguy merged commit 8084400 into danielsdeleo:master May 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants