Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pspdfkit-cordova-android): add plugin #2840

Closed
wants to merge 5 commits into from

Conversation

radazzouz
Copy link
Contributor

⚠️ Note: I opened this pull request for visibility. It is still work in progress. It needs to be tested before reviewing it. ⚠️


This PR adds PSPDFKit Plugins for Android and iOS.

TODO:

  • Make sure that PSPDFKitCordovaiOS works in a newly created Ionic project.
  • Make sure that PSPDFKitCordovaAndroid works in a newly created Ionic project

@danielsogl danielsogl self-requested a review December 27, 2018 08:31
@danielsogl danielsogl self-assigned this Dec 27, 2018
@danielsogl danielsogl added WIP target: patch This PR is targeted for the next patch release labels Dec 27, 2018
@danielsogl danielsogl changed the title [WIP] Add PSPDFKit Cordova Plugins for Android and iOS feat(pspdfkit-cordova-android): add plugin Dec 28, 2018
@radazzouz
Copy link
Contributor Author

I was unsuccessful in running the plugin locally on iOS. I have not attempted to run Android yet.

I did follow the developer instruction here https://github.com/ionic-team/ionic-native/blob/master/DEVELOPER.md and it seems the plugin is not installed. I also did some extensive research (Stack Overflow, this repo, https://ionicframework.com/docs/native/, etc.) to try and find a solution. I may be missing an integration step.

I am attaching the sample project here for future reference.

How to Reproduce:

  • Download and unzip the sample project.
  • run npm install
  • Download PSPDFKit and place PSPDFKit.framework and PSPDFKitUI.framework in platforms/ios
  • run ionic cordova run ios

Expected:

The PDF should be presented.

Actual:

Nothing happens.

Additional information:

When I run the workspace from Xcode, I get logs like these:

019-01-11 11:12:52.075611-0500 IonicDemo[4644:1770849] WARN: Ionic Native: tried calling PSPDFKitCordovaIOS.present, but the PSPDFKitCordovaIOS plugin is not installed.
2019-01-11 11:12:52.075969-0500 IonicDemo[4644:1770849] WARN: Install the PSPDFKitCordovaIOS plugin: 'ionic cordova plugin add pspdfkit-cordova-ios'

@radazzouz
Copy link
Contributor Author

Closing in favor of #3210

@radazzouz radazzouz closed this Oct 23, 2019
@radazzouz radazzouz deleted the pspdfkit-cordova-ios branch October 23, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: patch This PR is targeted for the next patch release WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants