Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(firebase-x): add missing methods, parameter #3273

Merged
merged 3 commits into from
Jan 3, 2020
Merged

feat(firebase-x): add missing methods, parameter #3273

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfef248
feat(firebase-x): add colletion enable methods
kodolok Jan 1, 2020
c921dcd
feat(firebase-x): add parameter to logError
kodolok Jan 1, 2020
443c1cf
fixed whitespace errors
kodolok Jan 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/@ionic-native/plugins/firebase-x/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,26 @@ export class FirebaseX extends IonicNativePlugin {
return;
}

/**
* Enable/disable Crashlytics collection.
* @param {boolean} enabled
* @returns {Promise<any>}
*/
@Cordova()
setCrashlyticsCollectionEnabled(enabled: boolean): Promise<any> {
return;
}

/**
* Enable/disable performance collection.
* @param {boolean} enabled
* @returns {Promise<any>}
*/
@Cordova()
setPerformanceCollectionEnabled(enabled: boolean): Promise<any> {
return;
}

/**
* Log an event using Analytics
* @param {string} type
Expand Down Expand Up @@ -387,10 +407,11 @@ export class FirebaseX extends IonicNativePlugin {
* The error message will appear in the Logs section of the non-fatal error event.
* Also logs the error message to the native device console.
* @param {string} error
* @param {object} (optional) a stack trace generated by stacktrace.js
* @return {Promise<any>}
*/
@Cordova()
logError(error: string): Promise<any> {
logError(error: string, stackTrace?: object): Promise<any> {
return;
}

Expand Down