fix(in-app-browser): adds missing customscheme type #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it also adds an overload to the `on` function to pass a generic string to support custom events.
danielsogl
approved these changes
Jan 3, 2020
This was referenced Jan 11, 2020
This was referenced Mar 15, 2020
This was referenced Apr 7, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue of the missing event that is supported by the InAppBrowser plugin: #3142 (comment)
This change also adds support for custom events by adding a method overload to support a generic
string. By adding the overload the IDEs can still provide intellisense for the known events.Custom events are very well a thing: apache/cordova-plugin-inappbrowser#514 (comment)
The only downside (but
lib.dom.tshas it, too) is that thetypeproperty of theInAppBrowserEventneeds to be changed to astring, too.