Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fcm): add missing clearAllNotifications, hasPermission and getAPNSToken #3331

Merged
merged 3 commits into from Feb 28, 2020
Merged

fix(fcm): add missing clearAllNotifications, hasPermission and getAPNSToken #3331

merged 3 commits into from Feb 28, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 27, 2020 •
edited by danielsogl
Loading

fixes: #3330

@ghost
Copy link
Author

ghost commented Feb 28, 2020 •
edited by ghost
Loading

Please let me know if I should cherry-pick and address #3206 and #3205 in here?
cc @AlexisCaffa @danielsogl

Alexis Caffa added 2 commits February 28, 2020 17:52
getAPNSToken method added
c5cbf55 
New version of `cordova-plugin-fcm-with-dependecy-updated` released: v4.0.0

_“The old FCMPlugin.getToken is focused on retrieving the FCM Token. For the IOS, APNS token can now be retrieved by the new method”_ (Show readme)[https://github.com/andrehtissot/cordova-plugin-fcm-with-dependecy-updated#version-400-12102019]
hasPermission added
b141d8c 
[Show readme.md](https://github.com/andrehtissot/cordova-plugin-fcm-with-dependecy-updated#version-320-16092019)

#### Checking for permissions
Useful for IOS. On android, it will always return `true`.

```javascript
FCMPlugin.hasPermission(function(doesIt){
    // doesIt === true => yes, push was allowed
    // doesIt === false => nope, push will not be available
    // doesIt === null => still not answered, recommended checking again later
    if(doesIt) {
        haveFun();
    }
});
```
# Conflicts:
#	src/@ionic-native/plugins/fcm/index.ts
@ghost ghost changed the title fix(fcm): add missing clearAllNotifications fix(fcm): add missing clearAllNotifications, hasPermission and getAPNSToken Feb 28, 2020
@ghost
Copy link
Author

ghost commented Feb 28, 2020

Went ahead, hope that's fine with you. Cherry-picked commits are co-authored.

@danielsogl danielsogl self-assigned this Feb 28, 2020
@danielsogl danielsogl added the target: patch This PR is targeted for the next patch release label Feb 28, 2020
@danielsogl danielsogl merged commit 18bee4e into danielsogl:master Feb 28, 2020
This was referenced Feb 29, 2020
Closed
Closed
This was referenced Mar 21, 2020
Merged
Merged
Merged
This was referenced Apr 3, 2020
Merged
Merged
Closed
Closed
Merged
Merged
This was referenced Apr 13, 2020
Closed
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danielsogl danielsogl

Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing clearAllNotifications on FCM plugin
1 participant
@danielsogl