Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queues priority to metrics only works in redis #204

Closed
wants to merge 4 commits into from

Conversation

ahelmy
Copy link
Contributor

@ahelmy ahelmy commented Jan 9, 2023

@danihodovic
Copy link
Owner

Could we add a test for this?

@ahelmy
Copy link
Contributor Author

ahelmy commented Jan 9, 2023

It would be hard for the moment, I need to understand how test working in this repo.
But I tested locally and works perfect with redis.

@danihodovic
Copy link
Owner

We will need a test to prevent future changes from breaking this logic. I can give you some help with the test, but the earliest would be later this month. We use Redis, but not queue priorities so it's not a pressing matter for us.

@ahelmy
Copy link
Contributor Author

ahelmy commented Jan 9, 2023

appreciating your guidance, priority queue could be applied to Redis as well and its used normally so important to support that

@ahelmy
Copy link
Contributor Author

ahelmy commented Mar 18, 2023

@danihodovic Please find unit testing, late better than nothing :D

@danihodovic
Copy link
Owner

Hi @ahelmy,

Sorry about the long time until review. I've been busy with other projects.

I think adding queue priority is a seldom used feature (especially with Redis) and it complicates the celery-exporter code. At the moment I prefer not to merge it as I'm not using it in any of my projects and this is the first feature request I get.

If you would like to support it please fork the project.

Thank you,
Dani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants