Allow mouse coordinate updates outside of terminal window #2741
Conversation
| @@ -1768,6 +1742,12 @@ build_cflow_automaton(inputctx* ictx){ | |||
| { "[E", simple_cb_begin, }, | |||
| { "[<\\N;\\N;\\NM", mouse_press_cb, }, | |||
| { "[<\\N;\\N;\\Nm", mouse_release_cb, }, | |||
| { "[<\\N;-\\N;\\NM", mouse_press_cb, }, | |||
There was a problem hiding this comment.
From a quick test it seems kitty, ghostty, xterm and urxvt do. alacritty, wezterm, gnome-terminal don't.
| @@ -567,19 +567,6 @@ pixelmouse_click(inputctx* ictx, ncinput* ni, long y, long x){ | |||
| x /= ictx->ti->cellpxx; | |||
| x -= ictx->lmargin; | |||
| y -= ictx->tmargin; | |||
| // convert from 1- to 0-indexing, and account for margins | |||
There was a problem hiding this comment.
ugh, i should really probably have factored these out. if you're getting rid of them, i guess it doesn't matter.
| { "[<\\N;\\N;-\\NM", mouse_press_cb, }, | ||
| { "[<\\N;\\N;-\\Nm", mouse_release_cb, }, | ||
| { "[<\\N;-\\N;-\\NM", mouse_press_cb, }, | ||
| { "[<\\N;-\\N;-\\Nm", mouse_release_cb, }, |
There was a problem hiding this comment.
erp, i need some unit tests on this badly. i know touching it sometimes has unexpected results, due to a bug or bugs of mine.
There was a problem hiding this comment.
I've been using it daily for a few months without noticing any wierdness, but yeah, it didn't look like the "correct" fix to me.
|
just wanted to say i've finally got time to work on Notcurses again, and you can expect this PR to be reviewed/tested/merged/reworked/spindled/folded/mutilated this week. sorry for the delay! |
Most terminals send mouse updates even when the cursor is outside of the terminal window if a button is pressed. This makes dragging operations potentially much easier for the user because they are not required keep the mouse cursor precisely inside the window while dragging.
For example, when dragging a scrollbar it may be easy click intially, but quite difficult to drag without touching the edge of the terminal window.
These two commit fix related issues in notcurses.
Comments very welcome.