t: Fix indirect syntax
#176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the usage of indirect object syntax in test files. The syntax is discouraged here: https://perldoc.perl.org/perlobj#Indirect-Object-Syntax
|
I don't know how to resolve those non-Unicode file cases. |
dankogai
added a commit
that referenced
this pull request
Nov 3, 2023
dankogai
added a commit
that referenced
this pull request
Nov 3, 2023
|
You can use perl to do that! perl -i.bak -ple 's/import Config/Config->import()/' t/*.tI so did in 4bada5c . I so did and made sure all occurances of grep 'import Config' `awk '{print $1}' MANIFEST`
And CI is now happy. https://github.com/dankogai/p5-encode/actions/runs/6740663118 Thank you for addressing this issue. Though functionally identical your point is still relevant. Dan the Maintainer Thereof |
|
Thanks @dankogai ! |
jkeenan
pushed a commit
to Perl/perl5
that referenced
this pull request
Nov 10, 2023
$Revision: 3.20 $ $Date: 2023/11/10 01:10:50 $ ! t/Aliases.t t/CJKT.t t/Encode.t t/Encoder.t t/Unicode.t t/at-cn.t t/at-tw.t t/enc_data.t t/enc_eucjp.t t/enc_module.t t/enc_utf8.t t/encoding.t t/fallback.t t/grow.t t/gsm0338.t t/guess.t t/jperl.t t/magic.t t/mime-header.t t/mime-name.t t/perlio.t t/rt113164.t t/rt65541.t t/rt76824.t t/rt85489.t t/rt86327.t t/truncated_utf8.t t/utf8strict.t t/rt.pl Fix indirect syntax accordingly to (but not by pulling): dankogai/p5-encode#176 ! bin/enc2xs Pulled: enc2xs: Fix indirect syntax dankogai/p5-encode#174 ! bin/encguess Pulled: encguess: remove duplicate "the" dankogai/p5-encode#173 ! bin/enc2xs Pulled: Fix spelling in comment dankogai/p5-encode#171 ! t/gsm0338.t Pulled: fix gsm0338 test compatibility with perl < 5.8.8 dankogai/p5-encode#170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the usage of indirect object syntax
in test files.
The syntax is discouraged here:
https://perldoc.perl.org/perlobj#Indirect-Object-Syntax