Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to parse json trusted setup to txt #12

Conversation

dgcoffman
Copy link

@dgcoffman dgcoffman commented Nov 17, 2022

Adds a function to the NodeJS bindings which will parse the JSON format of e.g. https://raw.githubusercontent.com/ethereum/consensus-specs/dev/presets/mainnet/trusted_setups/testing_trusted_setups.json to the text format required by c-kzg.

@dgcoffman dgcoffman changed the title Dgc/add ability to parse json trusted setup to txt Add ability to parse json trusted setup to txt Nov 17, 2022
@dgcoffman dgcoffman marked this pull request as ready for review November 17, 2022 02:33
expect(verifyAggregateKzgProof([], [], computeAggregateKzgProof([]))).toBe(
true,
);
});
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently throws verify_aggregate_kzg_proof failed with error code: 1 which means verify_aggregate_kzg_proof returned C_KZG_BADARGS

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine while ethereum/consensus-specs#3093 has not been merged

@dgcoffman dgcoffman force-pushed the dgc/add-ability-to-parse-json-trusted-setup-to-txt branch from e88b3e6 to 3bd84cf Compare November 18, 2022 00:41
@xrchz xrchz merged commit 2745c54 into dankrad:4844 Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants