-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aligned and optimized unique error handling #5280
Conversation
I will tackle the impact of |
Still needs some unit tests (in case they don't exist yet). |
3b908b2
to
bd0cec3
Compare
This is madness - we check for unique messages in three different places. Hopefully the |
I still want to try to add unit tests for the code I changed. |
2767b0d
to
2cfb0a4
Compare
Some of the additional tests are quite blackbox-y and seem redundant but since the logic is all over the place at the moment we need those test to make sure that logic is in place before we move it in the future. |
a322f58
to
89b0735
Compare
This has sufficient testing now. I also finally have a better understanding how the different |
c57c98d
to
9f29c4b
Compare
…and `Executor::hasToLog()`
The handling in
CppCheck::reportErr()
andExecutor::hasToLog()
was slightly different. I hope this can somehow be shared after the executor reworking.We were also using a very inappropriate container for the error list which caused a lot of overhead.
-D__GNUC__ --debug-warnings --template=daca2 --check-library -j2 ../test/testsymboldatabase.cpp
Clang 15
main process
284,218,587
->175,691,241
worker process
9,123,697,183
->8,951,903,360