Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/CMakeLists.txt: use $<TARGET_FILE:testrunner> #6871

Merged
merged 1 commit into from
Oct 7, 2024
Merged

test/CMakeLists.txt: use $<TARGET_FILE:testrunner> #6871

merged 1 commit into from
Oct 7, 2024

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Oct 7, 2024

No description provided.

danmar
danmar approved these changes Oct 7, 2024
View reviewed changes
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. I just trust you that this is better.

@firewave
Copy link
Collaborator Author

firewave commented Oct 7, 2024

I have no idea. I just trust you that this is better.

Before it was using the hard coded process name testrunner - now it uses the output file generated by the target testrunner.

I am actually a bit surprised that worked as the executable needed to be in the path to be found.

@firewave firewave merged commit 629ec44 into danmar:main Oct 7, 2024
63 checks passed
@firewave firewave deleted the target branch October 7, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firewave @danmar