bugfix/feat:Allow other LDAP field besides "mail" to map to email adress, or fallback to made up email #4127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mxbonn
changed the title
Mxbonn
added a commit
to Mxbonn/librechat.ai
that referenced
this pull request
Sep 20, 2024
danny-avila
force-pushed
the
bugfix/ldap-email
branch
from
5ed90f9
to
b449682
Compare
5 tasks
|
Replaced by #4177 lgtm overall but I added a warning for the new fallback behavior |
danny-avila
pushed a commit
to LibreChat-AI/librechat.ai
that referenced
this pull request
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
if the
userinfoof LDAP does not return amailfield, librechat will not authenticate even if ldap authenticated succesfully.Change Type
Please delete any irrelevant options.
Testing
Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.
Test Configuration:
Checklist
Please delete any irrelevant options.