Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests #22

Merged
merged 1 commit into from
Sep 12, 2013
Merged

Added tests #22

merged 1 commit into from
Sep 12, 2013

Conversation

koenpunt
Copy link
Collaborator

Added test and fixed an issue with optional url parts not being correctly stripped:

# Before without the type param
/bar/[:controller]/[:action].[:type]? => /bar/test/action.

# Now without the type param
/bar/[:controller]/[:action].[:type]? => /bar/test/action

Although there is still one issue left:

# URL                With route
/bar/test/do.json => /bar/[:controller]/[:action].[:type]?

# Results in
array('controller' => 'test', 'action' => 'do.json');

# Should result in
array('controller' => 'test', 'action' => 'do', 'type' => 'json');

dannyvankooten added a commit that referenced this pull request Sep 12, 2013
@dannyvankooten dannyvankooten merged commit 8d13b59 into dannyvankooten:master Sep 12, 2013
@koenpunt koenpunt deleted the added-test branch September 12, 2013 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants