Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add check for bad basePath #279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add check for bad basePath #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions AltoRouter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,14 @@ public function match($requestUrl = null, $requestMethod = null)
$requestUrl = isset($_SERVER['REQUEST_URI']) ? $_SERVER['REQUEST_URI'] : '/';
}

// check if basePath is in requestUrl
// exemple of problem : space in basePath will be replace be %20 in requestUrl
// so next check substr() will not work
if (strpos($requestUrl, $this->basePath) !== 0 ){
throw new Exception("Error Processing Request : requestUrl is not starting with basePath. Do you forget to use setBasePath() OR basePath contains illegal characters", 1);
}


// strip base path from request url
$requestUrl = substr($requestUrl, strlen($this->basePath));

Expand Down