Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition Behaviours Extended #159

Merged
merged 8 commits into from
Jul 10, 2020
Merged

Conversation

danobot
Copy link
Owner

@danobot danobot commented Jun 21, 2020

This PR implements transition behaviours as to allow some change to the behaviour. Cleans up implemention added in v6.0.0 and extends the number of transition points.

The behaviour implemented with end_time_action and start_time_action has been replaced with a more generic callback to make it the same as the other callbacks.

    behaviours:
      on_enter_constrain: "ignore"
      on_exit_constrain: "ignore"

Before opening a pull request, please ensure:

  • Double-check your branch is based on develop and targets develop
  • I have commented my code, particularly in hard-to-understand areas
  • The PR title is clear, concise and follows conventional commit formatting.
  • README documentation is updated for new features (VERY IMPORTANT, undocumented features cannot be discovered and used!)
  • Description explains the issue/use-case resolved and auto-closes related issues.

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

IMPORTANT: By submitting a patch, you agree to allow the project owners to license your work under the terms of the MIT License.

Description

Related Issues

Closes #154

@danobot danobot merged commit aa8dab9 into develop Jul 10, 2020
@danobot danobot deleted the transition-behaviour-extended branch September 5, 2020 09:30
danobot added a commit that referenced this pull request Oct 23, 2020
* Update __init__.py

* Update const.py

* Update __init__.py

* Update const.py

* Update __init__.py

* Update __init__.py

* license

* feat: clean up

Co-authored-by: Daniel Mason <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant