Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: rename stay mode to make the feature easier to understand (#176) #177

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

danobot
Copy link
Owner

@danobot danobot commented Sep 4, 2020

BREAKING CHANGE: Check the docs for new stay_mode configuration field and the name changes to the related services.

Thank you for contributing!

Please open an issue before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

  • Double-check your branch is based on develop and targets develop
  • I have commented my code, particularly in hard-to-understand areas
  • The PR title is clear, concise and follows conventional commit formatting.
  • README documentation is updated for new features or changes in behaviour to existing features (VERY IMPORTANT, undocumented features cannot be discovered and used!)
  • Description explains the issue/use-case resolved and auto-closes related issues.
  • Breaking changes or changes in behaviour are called out and discussed in separate issues.

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

IMPORTANT: By submitting a patch, you agree to allow the project owners to license your work under the terms of the project license.

Description

Related Issues

Closes #143

BREAKING CHANGE: Check the docs for new `stay_mode` configuration field and the name changes to the related services.
@danobot danobot merged commit 9f7ec54 into master Sep 4, 2020
danobot added a commit that referenced this pull request Oct 23, 2020
… (#177)

BREAKING CHANGE: Check the docs for new `stay_mode` configuration field and the name changes to the related services.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"stay" mode names (flag and service) are confusing
1 participant