Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apply all EC configurations in HA config packages #201

Merged
merged 1 commit into from
Oct 11, 2020
Merged

fix: Apply all EC configurations in HA config packages #201

merged 1 commit into from
Oct 11, 2020

Conversation

chishm
Copy link
Contributor

@chishm chishm commented Oct 11, 2020

Thank you for contributing!

Please open an issue before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

  • Double-check your branch is based on develop and targets develop
  • I have commented my code, particularly in hard-to-understand areas
  • The PR title is clear, concise and follows conventional commit formatting.
  • README documentation is updated for new features or changes in behaviour to existing features (VERY IMPORTANT, undocumented features cannot be discovered and used!)
  • Description explains the issue/use-case resolved and auto-closes related issues.
  • Breaking changes or changes in behaviour are called out and discussed in separate issues.

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

IMPORTANT: By submitting a patch, you agree to allow the project owners to license your work under the terms of the project license.

Description

Fix support for packages in HA configuration by iterating all entity_controller: keys. This allows users to separate the EC configuration into multiple files.

A basic configuration example follows.

configuration.yaml:

homeassistant:
  packages: !include_dir_named packages

packages/room1.yaml:

entity_controller:
  room1_ec:
    sensors:
      - binary_sensor.room1
    entities:
      - light.room1

packages/room2.yaml:

entity_controller:
  room2_ec:
    sensors:
      - binary_sensor.room2
    entities:
      - light.room2

Related Issues

Closes

Allow multiple `entity_controller:` keys in the HA configuration YAML by
applying all that are found. This adds support for using `packages` to
separate the EC config into multiple files.
@danobot
Copy link
Owner

danobot commented Oct 11, 2020

Looks good, please target develop branch and I'll merge

@chishm chishm changed the base branch from master to develop October 11, 2020 11:23
@chishm
Copy link
Contributor Author

chishm commented Oct 11, 2020

I've updated the pull request to target the develop branch now.

Thanks for responding to this so quickly. Also, thank you for writing EC, it's made using my motion sensors a lot easier.

@danobot danobot merged commit 455023d into danobot:develop Oct 11, 2020
danobot added a commit that referenced this pull request Oct 23, 2020
fix: Apply all EC configurations in HA config packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants