Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically hide scroller when not scrolling (issue #4) #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

h6ah4i
Copy link
Contributor

@h6ah4i h6ah4i commented Feb 20, 2015

This is a enhancement PR intended to support the issue #4.

Introduced these public methods:

  • AbsRecyclerViewFastScroller.isFastScrollAlwaysVisible()
  • AbsRecyclerViewFastScroller.setFastScrollAlwaysVisible(boolean alwaysVisible)
  • AbsRecyclerViewFastScroller.setIsGrabbingHandle(boolean isGrabbingHandle)

@danoz73
Copy link
Owner

danoz73 commented Feb 23, 2015

Hi @h6ah4i! Thanks so much for contributing. I will get back to you later in the week on this one when I have some more time (in the middle of something else right now).

Will respond soon.

@h6ah4i
Copy link
Contributor Author

h6ah4i commented Feb 23, 2015

Hi! Thanks for your response. I have rebased this branch and fixed the conflict.

@h6ah4i h6ah4i changed the title Automatically hide scroller when not scrolling Automatically hide scroller when not scrolling (issue #4) Feb 23, 2015
…ically hide)

Introduced these public methods:

- AbsRecyclerViewFastScroller.isFastScrollAlwaysVisible()
- AbsRecyclerViewFastScroller.setFastScrollAlwaysVisible(boolean alwaysVisible)
- AbsRecyclerViewFastScroller.setIsGrabbingHandle(boolean isGrabbingHandle)
@h6ah4i
Copy link
Contributor Author

h6ah4i commented Feb 25, 2015

Rebased to the latest master.

@h6ah4i
Copy link
Contributor Author

h6ah4i commented Feb 28, 2015

Hi @danoz73 . I have made a lot of changes in my forked branch and I hope they will be merged to your master branch soon. However, I do not submit pull requests except for this one yet in order to avoid conflictions. I am going to submit a pull request one by one, but is it too much of a hassle?

https://github.com/h6ah4i/RecyclerViewFastScroller/tree/develop

@danoz73
Copy link
Owner

danoz73 commented Feb 28, 2015

No I was looking at your pull request and was trying to decide how to make
the auto hide functionality more of a module to the scroller.

I'm very interested in keeping all objects as independent as possible, and
I can easily see the auto hiding being a good candidate for some sort of
'AutoHideController' or something of the sort as opposed to just sticking
it in the same class.

On Fri, Feb 27, 2015, 6:21 PM Haruki Hasegawa [email protected]
wrote:

Hi @danoz73 https://github.com/danoz73 . I have made a lot of changes
in my forked branch and I hope they will be merged to your master branch
soon. However, I do not submit pull requests except for this one yet in
order to avoid conflictions. I am going to submit a pull request one by
one, but is it too much of a hassle?

https://github.com/h6ah4i/RecyclerViewFastScroller/tree/develop


Reply to this email directly or view it on GitHub
#7 (comment)
.

@h6ah4i
Copy link
Contributor Author

h6ah4i commented Feb 28, 2015

Thanks for the reply. Yeah, current my code is not clean and requires refactoring. I agree to make a sort of AutoHideController class ;)

@ThomasdenH
Copy link

I think it would be easy enough to make it a boolean value. Just make that and the timing adjustable. Or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants