Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rowBind-kernel for CSRMatrix #217

Closed
daphne-eu opened this issue Mar 11, 2022 · 1 comment · Fixed by #344
Closed

rowBind-kernel for CSRMatrix #217

daphne-eu opened this issue Mar 11, 2022 · 1 comment · Fixed by #344
Assignees
@akroviakov
Labels
good first issue Non-urgent, simple task with limited scope, suitable for getting started as a contributor.

Comments

@daphne-eu
Copy link
Owner

In GitLab by @pdamme on Mar 11, 2022, 12:48

The rowBind-operation concatenates two matrices or frames lhs and rhs vertically and returns the result as a new data object res. The two inputs must have the same number of columns.

Example

lhs: 1, 2, 3,
     4, 5, 6,

rhs: 0, 1, 0,
     1, 0, 1,
     0, 1, 0,

res: 1, 2, 3,
     4, 5, 6,
     0, 1, 0,
     1, 0, 1,
     0, 1, 0,

We already have specializations of the rowBind-kernel for DenseMatrix and Frame, but still lack one for CSRMatrix.

This issue asks you to implement

  1. A partial specialization of the kernel struct for CSRMatrix as the data type implementation of all input and output matrices.
  2. Ideally some test cases.

Hints
@akroviakov
Copy link
Collaborator

Assigned to @akroviakov.

@akroviakov akroviakov mentioned this issue Apr 28, 2022
Merged
pdamme pushed a commit that referenced this issue Apr 29, 2022
@akroviakov
[DAPHNE-#217]: rowBind-kernel for CSRMatrix (#344)
855a2d0 
- Implements row binding for CSRMatrix datatype.
- Adds a new property check isView() for CSRMatrix datatype.
- Closes #217.

Co-authored-by: Artem Kroviakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akroviakov akroviakov

Labels
good first issue Non-urgent, simple task with limited scope, suitable for getting started as a contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DAPHNE-#217]: rowBind-kernel for CSRMatrix akroviakov/daphne
2 participants
@daphne-eu @akroviakov