Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DaphneDSL: Type casting matrices #356

Closed
RetoKrummenacher opened this issue May 6, 2022 · 1 comment · Fixed by #361
Closed

DaphneDSL: Type casting matrices #356

RetoKrummenacher opened this issue May 6, 2022 · 1 comment · Fixed by #361
Assignees

Comments

@RetoKrummenacher
Copy link

The type conversion on matrices is not working.

A = rand(5,5,0.0,1.0,1,-1);
print(A);
B = as.matrix.f32(A);
# Output:
# JIT session error: Symbols not found: 
#[ _cast__DenseMatrix_float__DenseMatrix_double ]

grafik

@RetoKrummenacher RetoKrummenacher changed the title Type casting matrices DaphneDSL: Type casting matrices May 6, 2022
@aristotelis96 aristotelis96 self-assigned this May 9, 2022
@aristotelis96
Copy link
Collaborator

aristotelis96 commented May 9, 2022

Thank you @RetoKrummenacher for this issue. PR #337 implemented the kernel for casts between different value types of a DenseMatrix, however src/runtime/local/kernels/kernels.json is missing the entries. I've created a PR that should fix this.

pdamme pushed a commit that referenced this issue May 12, 2022
- Added entries to kernels.json for CastObj kernel.
- CastObj has already implementation of DenseMatrix<ValueType> to DenseMatrix<ResultValueType>, but kernels.json was missing the declarations.
- Closes #356.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants