Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAPHNE-191] Refactor CUDA buffer mgmt (aka introducing Object Meta D… #334

Merged
merged 4 commits into from
Aug 25, 2022
Merged

[DAPHNE-191] Refactor CUDA buffer mgmt (aka introducing Object Meta D… #334

merged 4 commits into from
Aug 25, 2022

Commits on Aug 25, 2022

  1. [DAPHNE-191] Refactor CUDA buffer mgmt (aka introducing Object Meta D… 

    …ata)

This change introduces a major change how external storage buffers (CUDA memory specifically) are handled. In that regard, the following noteworthy changes are implemented:
* Factor out CUDA allocations from DenseMatrix (one of the initial motivations of issue #191)
* Introduce a mechanism to handle several storage backends and track ranges of a Structure's data.
* To make use of the mechanism, an AllocationDescriptor is passed to create() and getValues() (at the moment only DenseMatrix is supported).
* Allocation descriptors need to implement the IAllocationDescriptor interface. This decouples backend specific dependencies.
* AllocationDescriptorHost and AllocationDescriptorCUDA are implemented atm. The former is more or less a no-op for now.
* The CUDA memory allocation and data movement is moved to the CUDAContext class. It keeps track of its allocations per device. For now this does nothing but can be used to reuse allocations in the future.

Closes #191, Closes #334
    @corepointer
    corepointer committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    888100b View commit details
    Browse the repository at this point in the history

  2. [MINOR] Optimized imports 

    The code contained in LoadPartitioning.h does not need to be included all over the place (through inclusion in DaphneUserConfig.h)
    @corepointer
    corepointer committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    ad59236 View commit details
    Browse the repository at this point in the history

  3. [BUGFIX] Restrict transpose optimization due to currently insufficien… 

    …t implementation
    @corepointer
    corepointer committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    ecab1df View commit details
    Browse the repository at this point in the history

  4. [MINOR] A debug print utility function for CUDA buffer content

    @corepointer
    corepointer committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    31a0852 View commit details
    Browse the repository at this point in the history