Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAPHNE-#218]: colBind-kernel for CSRMatrix #347

Merged
merged 3 commits into from
May 9, 2022
Merged

[DAPHNE-#218]: colBind-kernel for CSRMatrix #347

merged 3 commits into from
May 9, 2022

Conversation

akroviakov
Copy link
Collaborator

@pdamme pdamme self-requested a review May 9, 2022 19:06
@pdamme
Polishing.
92a8a99 
- Renamed loop variables for better readability and consistency.
  - colIdx was a bit misleading, since it was not an actual CSR colIdx (renamed to c).
  - Renamed resRow to r for consistency.
  - The other kernels often use r and c for the loop variables over rows/cols.
pdamme
pdamme approved these changes May 9, 2022
View reviewed changes
Copy link
Collaborator

@pdamme pdamme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks very good. I'll merge it in. I've only changed two variable names (see my latest commit).

@pdamme pdamme merged commit b2acaea into daphne-eu:main May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdamme pdamme pdamme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

colBind-kernel for CSRMatrix
2 participants
@akroviakov @pdamme