Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAPHNE-#494] SQLParser: Group by without aggregation clause not working #543

Merged
merged 7 commits into from
Jun 17, 2023
Merged

[DAPHNE-#494] SQLParser: Group by without aggregation clause not working #543

merged 7 commits into from
Jun 17, 2023

Commits on May 24, 2023

  1. Add simple test which checks if the SQL grouping works without an agg… 

    …regation function.
    @tomschw
    tomschw committed May 24, 2023
    Configuration menu
    Copy the full SHA
    1822674 View commit details
    Browse the repository at this point in the history

  2. Implement a workaround to allow the use of the group operation withou… 

    …t aggregations.
    @tomschw
    tomschw committed May 24, 2023
    Configuration menu
    Copy the full SHA
    56a5804 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Merge branch 'daphne-eu:main' into 494-group-without-agg

    @tomschw
    tomschw authored May 25, 2023
    Configuration menu
    Copy the full SHA
    4b39f61 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Hardcode the addition to the callee in the kernel lowering as a worka… 

    …round for grouping without aggregation.
    @tomschw
    tomschw committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    f89cfbb View commit details
    Browse the repository at this point in the history

  2. Merge branch '494-group-without-agg' of https://github.com/tomschw/da… 

    …phne into 494-group-without-agg
    @tomschw
    tomschw committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    685f945 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'daphne-eu:main' into 494-group-without-agg

    @tomschw
    tomschw authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    f21779d View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. Minor polishing and corrections. 

    - The shape inference for GroupOp did indeed have a bug, but this was not the right fix (using inferNumColsFromArgs() was generally wrong).
- Simplified the new test case for GROUP BY without aggregation.
    @pdamme
    pdamme committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    48f6767 View commit details
    Browse the repository at this point in the history