752 one hot and bin functions in daphne lib #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… seq() built-in function optional and defaults to one in DaphneLib
… Matrices in DaphneLib
pdamme
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Thanks for this contribution @saminbassiri. Making more DaphneDSL built-in functions available in DaphneLib is always useful! Your code looks very good to me. This PR is ready to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #752 and makes the
oneHotandbinbuilt-in functions available on matrices in DaphneLib.Features:
oneHot(info)to Applies one-hot-encoding on matrices in DaphneLib.bin(numBins, Min, Max)orbin(numBins)to apply binning on matrices in DaphneLib.Changes:
oneHotandbinbuilt-in functions for matrices in DaphneLib.test/api/python/, ensuring that execution works as expected.doc/DaphneLib/APIRef.mdto addoneHotandbinbuilt-in functions for matrices.The below changes are related to issue #666. Since using
seqfunction with optionalincargument is only implemented at the DSL level in PR #756 , to useseqfunction with optionalincin DaphneLib API we have these changes:doc/DaphneLib/APIRef.mdforseq()function with optionalincarguments.incoptional with default value1inseq()function in DaphneLib.