[DAPHNE-#867] Change ConfigParser::fileExists() behavior to not throw #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corepointer
added a commit
to corepointer/daphne
that referenced
this pull request
Oct 18, 2024
…not throw Changing the behavior of fileExists() to a boolean operation as suggested by the method's name. Throwing an exception us up to the caller of this method. Closes daphne-eu#867
corepointer
force-pushed
the
867-change-fileExists
branch
from
148ddc3
to
f97ea5a
Compare
|
The same semantic problem exists with keyExists() imho. Bit I'll leave that one for future work as my main concern to change this in the first place was a failing distributed test that did not find its config file. |
philipportner
approved these changes
Oct 18, 2024
…not throw Changing the behavior of fileExists() to a boolean operation as suggested by the method's name. Throwing an exception us up to the caller of this method. Closes daphne-eu#867
corepointer
force-pushed
the
867-change-fileExists
branch
from
f97ea5a
to
3e442ed
Compare
Since issues and pull requests share the same sequence number, I frequently abuse this to have a ticket number and a place for discussion right here in the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I consider this a bugfix but I'll run it through a PR to raise attention to the change. Tests are running fine (after fixing the one that tests the previous behavior). If there were no concerns raised by the time CI ran through I'll merge it right in.
Changing the behavior of fileExists() to a boolean operation as suggested by the method's name. Throwing an exception us up to the caller of this method.
Closes #867