Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover interrupted eventhubs subscriptions #3344

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

berndverst
Copy link
Member

Description

This is an attempt to recover eventhubs topic subscription upon error.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@berndverst berndverst requested review from a team as code owners February 8, 2024 19:25
@berndverst
Copy link
Member Author

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Feb 8, 2024

Components conformance test

🔗 Link to Action run

Commit ref: 528907c

❌ Some conformance tests failed

These tests failed:

  • pubsub.gcp.pubsub.terraform
  • pubsub.azure.eventhubs

@dapr-bot
Copy link
Collaborator

dapr-bot commented Feb 8, 2024

Components certification test

🔗 Link to Action run

Commit ref: 528907c

❌ Some certification tests failed

These tests failed:

  • bindings.azure.eventhubs
  • bindings.rabbitmq
  • pubsub.aws.snssqs
  • pubsub.azure.eventhubs
  • pubsub.mqtt3

@dapr-bot
Copy link
Collaborator

dapr-bot commented Feb 8, 2024

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: 528907c

@berndverst berndverst marked this pull request as draft February 8, 2024 19:57
Signed-off-by: Bernd Verst <[email protected]>
@berndverst berndverst marked this pull request as ready for review February 8, 2024 20:31
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just some comments for code readability

common/component/azure/eventhubs/eventhubs.go Show resolved Hide resolved
common/component/azure/eventhubs/eventhubs.go Outdated Show resolved Hide resolved
common/component/azure/eventhubs/eventhubs.go Outdated Show resolved Hide resolved
common/component/azure/eventhubs/eventhubs.go Outdated Show resolved Hide resolved
@berndverst
Copy link
Member Author

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Feb 8, 2024

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: bb2e600

@dapr-bot
Copy link
Collaborator

dapr-bot commented Feb 8, 2024

Components conformance test

🔗 Link to Action run

Commit ref: bb2e600

✅ All conformance tests passed

All tests have reported a successful status

@dapr-bot
Copy link
Collaborator

dapr-bot commented Feb 8, 2024

Components certification test

🔗 Link to Action run

Commit ref: bb2e600

❌ Some certification tests failed

These tests failed:

  • bindings.rabbitmq
  • pubsub.aws.snssqs
  • pubsub.mqtt3
  • pubsub.pulsar

Signed-off-by: Bernd Verst <[email protected]>
@berndverst berndverst merged commit 5445cea into dapr:main Feb 8, 2024
85 of 87 checks passed
berndverst added a commit to berndverst/components-contrib that referenced this pull request Feb 8, 2024
berndverst added a commit that referenced this pull request Feb 8, 2024
berndverst added a commit to berndverst/components-contrib that referenced this pull request Feb 8, 2024
@yaron2
Copy link
Member

yaron2 commented Feb 8, 2024

Components certification test

🔗 Link to Action run

Commit ref: bb2e600

❌ Some certification tests failed

These tests failed:

  • bindings.azure.eventhubs
  • bindings.rabbitmq
  • pubsub.aws.snssqs
  • pubsub.mqtt3
  • pubsub.pulsar

Tests failed here, including the eventhubs one.

berndverst added a commit that referenced this pull request Feb 8, 2024
berndverst added a commit that referenced this pull request Feb 8, 2024
@berndverst
Copy link
Member Author

Components certification test

🔗 Link to Action run
Commit ref: bb2e600

❌ Some certification tests failed

These tests failed:

  • bindings.azure.eventhubs
  • bindings.rabbitmq
  • pubsub.aws.snssqs
  • pubsub.mqtt3
  • pubsub.pulsar

Tests failed here, including the eventhubs one.

@yaron2 the eventhubs bindings test passed in this PR before - problem is that the 4 conformance and certification tests for eventhubs can't be run in parallel - they weren't designed well, so you manually need to restart them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants