-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recover interrupted eventhubs subscriptions #3344
Conversation
Signed-off-by: Bernd Verst <[email protected]>
/ok-to-test |
Components conformance testCommit ref: 528907c ❌ Some conformance tests failedThese tests failed:
|
Components certification testCommit ref: 528907c ❌ Some certification tests failedThese tests failed:
|
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 528907c |
Signed-off-by: Bernd Verst <[email protected]>
91fb6b4
to
bb2e600
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just some comments for code readability
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: bb2e600 |
Components conformance testCommit ref: bb2e600 ✅ All conformance tests passedAll tests have reported a successful status |
Components certification testCommit ref: bb2e600 ❌ Some certification tests failedThese tests failed:
|
Signed-off-by: Bernd Verst <[email protected]>
Signed-off-by: Bernd Verst <[email protected]>
…ns (#3344) (#3345) Signed-off-by: Bernd Verst <[email protected]>
Signed-off-by: Bernd Verst <[email protected]>
Tests failed here, including the eventhubs one. |
#3344) (#3346) Signed-off-by: Bernd Verst <[email protected]>
Signed-off-by: Bernd Verst <[email protected]>
@yaron2 the eventhubs bindings test passed in this PR before - problem is that the 4 conformance and certification tests for eventhubs can't be run in parallel - they weren't designed well, so you manually need to restart them. |
Description
This is an attempt to recover eventhubs topic subscription upon error.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
* [ ] Created/updated tests* [ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]