Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct OTel endpointAddress argument (it's not a URL) [v1.13 update] #4145

Merged
merged 4 commits into from
May 22, 2024

Conversation

andrejpk
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

The Tracing docs imply that you should use a URL in tracing.otel.endpointAddress but it's looking for a hostname or hostname:port

Issue reference

#4068

Copy link

Stale PR, paging all reviewers

@hhunter-ms hhunter-ms closed this May 21, 2024
@hhunter-ms hhunter-ms reopened this May 21, 2024
@KrylixZA
Copy link
Contributor

Thanks for this. Tripped me up for a while. I was doing what the docs told me to do but the app was telling me I had too many slashes. Neither was informative of what was incorrectly configured. This should clarify things.

@hhunter-ms hhunter-ms merged commit 666b3af into dapr:v1.13 May 22, 2024
9 checks passed
@yaron2 yaron2 added this to the 1.14 milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants