Skip to content

Commit

Permalink
Implement hide-autofill-popup
Browse files Browse the repository at this point in the history
fix brave#3816
fix brave#4540
fix brave#5023

Auditors: @bbondy

Test Plan:
1. Go to https://github.com/brave/browser-laptop/issues
2. In the filters textbox, start typing characters until autocomplete pops up
3. Push enter to submit
4. Scroll the page should dismiss the popup

1. Go to https://github.com/brave/browser-laptop/issues
2. In the filters textbox, start typing characters until autocomplete pops up
3. Push enter to submit
4. Popup should be dismissed
  • Loading branch information
darkdh committed Oct 31, 2016
1 parent 170a14e commit 68d8db6
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions js/components/frame.js
Original file line number Diff line number Diff line change
Expand Up @@ -804,8 +804,10 @@ class Frame extends ImmutableComponent {
contextMenus.onShowAutofillMenu(e.suggestions, e.rect, this.frame)
})
this.webview.addEventListener('hide-autofill-popup', (e) => {
// TODO(Anthony): conflict with contextmenu
// windowActions.setContextMenuDetail()
let webContents = this.webview.getWebContents()
if (webContents && webContents.isFocused()) {
windowActions.setContextMenuDetail()
}
})
this.webview.addEventListener('ipc-message', (e) => {
let method = () => {}
Expand Down

0 comments on commit 68d8db6

Please sign in to comment.