ashift : fix reuse of direct straigthening #10455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlicVB
added
bugfix
|
Looks good to me. Thanks @AlicVB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fix #10453
the fix here is "just" on the "help tool" for straightening with right-click+drag. So it doesn't change anything in params or process.
if rotate and perspective has more than just rotation applied, we can't rely anymore on transformed points. So let's "just" apply the rotation on top of the current one instead.
Note that in this case, we still can have some unexpected result, especially on image borders. This is due to the fact that perspective correction can change with rotation, but we can't really do anything for this case...
in my tests, I've not spotted any regressions, but better double check, as usual ;)