Fix memory requirement calculation #17608
Merged
+26
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Make sure in & output cl buffers are taken into account even if input is existing 2. Fix requirements for guided masking filter 3. Fix requirements for details mask. (requirements must be based on details->roi) 4. The log gets information about required memory via -d pipe
jenshannoschwalm
added
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #17569
Checked this also on my intel 630 notebook without issues. Checked the blur OpenCL code and couldn't spot anything suspicious yet, also not for the blend guided filter exept the wrong requirements calculations.