Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CE preview / UI stability #17609

Merged
merged 1 commit into from
Oct 6, 2024
Merged

CE preview / UI stability #17609

merged 1 commit into from
Oct 6, 2024

Conversation

jenshannoschwalm
Copy link
Collaborator

  1. We should correct blurring according to roi_scale and piece->iscale to make the guided filter working almost the same way.
  2. We can't find a fully-roi-unaware way to control the guiding but ensuring a minimum blur for the scharr sigma slightly helps.

Tested on integration testsuite 158 159

@jenshannoschwalm
CE preview / UI stability
2fca761 
1. We should correct blurring according to roi_scale and piece->iscale to make the
   guided filter working almost the same way.
2. We can't find a fully-roi-unaware way to control the guiding but ensuring a minimum
   blur for the scharr sigma slightly helps.

Tested on integration testsuite 158 159
@jenshannoschwalm jenshannoschwalm added priority: medium core features are degraded in a way that is still mostly usable, software stutters scope: UI user interface and interactions scope: image processing correcting pixels labels Oct 6, 2024
@jenshannoschwalm jenshannoschwalm added this to the 5.0 milestone Oct 6, 2024
TurboGit
TurboGit approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@TurboGit TurboGit merged commit 09a328f into darktable-org:master Oct 6, 2024
6 checks passed
@jenshannoschwalm jenshannoschwalm deleted the ce_preview_stability branch October 6, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboGit TurboGit TurboGit approved these changes

Assignees
No one assigned
Labels
priority: medium core features are degraded in a way that is still mostly usable, software stutters scope: image processing correcting pixels scope: UI user interface and interactions
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jenshannoschwalm @TurboGit