Physically move and copy selected images to a new folder

[minusdreidb]

• Selected images can be physically moved or copied to a new destination folder.
• The destination folder is imported as a new film roll, if it is not imported already.

Move specifics

• All duplicates of a selected image are also moved to the new destination for simplicity.
• Already generated xmp files are moved along with the images.
• The database entries for the moved images are updated to the new film roll id.

Copy specifics

• The selected images are copied to the new destination.
• The database entries for the images are duplicated with the new film roll id.
• Xmp files are generated at the destination, not copied from the source.

[hanatos]

works as advertised for me. not sure about the copy feature, do we need it? i guess removing features will always be kind of simple though. i'd also be interested in jose's opinion on this, he is working on a folder-based collection thing that might touch similar code.

diff seems clean and short, gui is kept very simple, so i think i can safely merge without loss of being future proof :)

thanks for that, i merged to master.

[minusdreidb]

great, i'm glad the move feature made it into dt.

after i've found the copy "file format" in the export module that also copies selected images and their xmps to a given folder, i'm not so sure about the copy feature myself. the only difference is, that the destination folder isn't imported as a film roll automatically like my implementation (which makes sense, as it is an export after all).

because i wasn't so sure about the copy feature myself at the time, i didn't add a config option allowing to disable the confirm dialog for the copy operation. originally i wanted to discuss the following on irc, but you were faster with your merge than i expected :) :

Depending on whether you want to keep the copy feature, i'd

• add the missing config option for the sake of completeness , or
• remove the copy feature

and open another pull request.

[jcsogo]

On Sun, Aug 12, 2012 at 8:52 AM, hanatos [email protected] wrote:

works as advertised for me. not sure about the copy feature, do we need
it? i guess removing features will always be kind of simple though. i'd
also be interested in jose's opinion on this, he is working on a
folder-based collection thing that might touch similar code.

I think it makes sense to have this feature. I will check the UI later, but
depending on how it is made, we can integrate it in my module, or make it
something complementary.

José Carlos García Sogo
[email protected]