Fix rotate by 90° crashes in rcd #8856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using rcd demosaicer and a pretty large image could lead to crashes. This was due to dt_iop_clip_and_zoom_roi_cl refusing to work via gpu and thus calling the error: section where some cl_mem tried to again dt_opencl_release_mem_object. The cl_mem's had already been released but not reset to NULL.
TurboGit
added
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using rcd demosaicer and a pretty large image could lead to crashes when doing a 90° rotation.
This was due to dt_iop_clip_and_zoom_roi_cl refusing to work via gpu and thus calling the error: section where some cl_mem tried to again dt_opencl_release_mem_object.
The cl_mem's had already been released but not reset to NULL.